Closed filmor closed 7 years ago
This looks great. In ErlMap.cs please move "Dictionary<IErlObject, IErlObject> _items;" to the private region, and rename the member to "m_Items" to match the project's coding style. Also, use 2-char space filling for intending.
I saw in another file that you are apparently using 4 spaces indents on namespaces and 2 on everything else. Is that really the plan?!
The current plan is to use 2 spaces across the board, but there may be some legacy leftovers to be fixed.
One more thing - why are the changes to Source/NFX/NFX.csproj needed?
They are not needed, I had to do them to get this running in my Visual Studio installation and committed them by accident. I'll remove them as soon as I'm done.
Please squash your commits.
I did just now, but you can nowadays just do that on merge.
Thank you for your contribution!
Still missing:
NFX.csproj
Decoding works already, though.