[WIP] Implementation for Erlang maps

aumcode / nfx

C# Server UNISTACK framework [MOVED]

https://github.com/agnicore/nfx

Other

391 stars 93 forks source link

[WIP] Implementation for Erlang maps #41

Closed filmor closed 7 years ago

filmor commented 7 years ago

Still missing:

[ ] Tests
[ ] Matching
[x] Some individual methods
[x] Reformatting to match the project's style
[x] Revert changes to NFX.csproj

Decoding works already, though.

saleyn commented 7 years ago

This looks great. In ErlMap.cs please move "Dictionary<IErlObject, IErlObject> _items;" to the private region, and rename the member to "m_Items" to match the project's coding style. Also, use 2-char space filling for intending.

filmor commented 7 years ago

I saw in another file that you are apparently using 4 spaces indents on namespaces and 2 on everything else. Is that really the plan?!

saleyn commented 7 years ago

The current plan is to use 2 spaces across the board, but there may be some legacy leftovers to be fixed.

saleyn commented 7 years ago

One more thing - why are the changes to Source/NFX/NFX.csproj needed?

filmor commented 7 years ago

They are not needed, I had to do them to get this running in my Visual Studio installation and committed them by accident. I'll remove them as soon as I'm done.

saleyn commented 7 years ago

Please squash your commits.

filmor commented 7 years ago

I did just now, but you can nowadays just do that on merge.

saleyn commented 7 years ago

Thank you for your contribution!