search

aumcode / serbench

CLR Serializer Benchmark Suite
Other
33 stars 11 forks source link

NetSerializer metadata is wrong #27

Closed tomba closed 9 years ago

tomba commented 9 years ago

NetSerializer uses custom binary format, not textual JSON as defined in the current SerializerInfo.

itadapter commented 9 years ago

correct it. and include the whole attr text here or send pull req

leo-gan commented 9 years ago

I will do this.

Regards,

Leonid Ganeline Microsoft Integration MVP (BizTalk Server) http://geekswithblogs.net/leonidganeline/

On Tue, Aug 4, 2015 at 10:10 AM, Dmitriy@ITAdapter <notifications@github.com

wrote:

correct it. and include the whole attr text here or send pull req

— Reply to this email directly or view it on GitHub https://github.com/aumcode/serbench/issues/27#issuecomment-127678438.

leo-gan commented 9 years ago

Fixed. Tomi, thank you for mention that!

tomba commented 9 years ago

Thanks @leo-gan, but you missed the line with:

FormatName = "JSON"

Sorry I wasn't clear on the wrong lines in my original report.

leo-gan commented 9 years ago

Done :)

Regards,

Leonid Ganeline Microsoft Integration MVP (BizTalk Server) http://geekswithblogs.net/leonidganeline/

On Tue, Aug 4, 2015 at 11:33 AM, Tomi Valkeinen notifications@github.com wrote:

Thanks @leo-gan https://github.com/leo-gan, but you missed the line with:

FormatName = "JSON"

Sorry I wasn't clear on the wrong lines in my original report.

— Reply to this email directly or view it on GitHub https://github.com/aumcode/serbench/issues/27#issuecomment-127704996.