aumhaa / monomodular

Ableton Live Python and Max Framework for various controllers
31 stars 8 forks source link

Modlink script bug #2

Closed novasnoa closed 10 years ago

novasnoa commented 10 years ago

columns and rows can be set in binary and with an offset, this you have to calculate back to decimal for the other controllers which dont understand binary. Mostly this works perfect.

the problem is there is also an option to set two binaries after each other in one message like "x_offset y 255 255" this will set all 16 leds in a row or col on the monome. this message would do the same as "0 0 255" + "8 0 255"

And this doesnt work in your script, You can see this problem with flin for example which uses this option.

aumhaa commented 10 years ago

Thanks for this observation. I will be spending some time on modlink asap, I have a few projects I have to finish up first. There are some other problems I'm aware of, as well.

aumhaa commented 10 years ago

If I understood the problem correctly, this should be fixed with the most recent push. Let me know if you find any other problems.

novasnoa commented 10 years ago

hey amounra,

i just checked it, was away for a while :)

But it still doesnt work for me.

in the video below i have flin running on 16 hight if all works well the lines should go also in the lower half of the 256 grid.

its not a problem of flin, it works in my emulation.

the problem is as i described above:

the problem is there is also an option to set two decimals after each other in one message like "x_offset y 255 255" this will set all 16 leds in a row or col on the monome. this message would do the same as "0 0 255" + "8 0 255"

http://www.youtube.com/watch?v=Vitd4KeXGPI&feature=youtu.be

novasnoa commented 10 years ago

ok here a second video, to make it clear :)

http://www.youtube.com/watch?v=JmHA-acTLS0

left side is your new modlink version right side is my edited version of your modlink. i did not edit the code but used objects to fix this bug.

aumhaa commented 10 years ago

Hey, thanks for this….I think I actually did fix it, I'm not sure what's going on, but I'll check and get back to you if I need further help. Appreciated :)

a

On Dec 21, 2013, at 9:09 AM, novasnoa notifications@github.com wrote:

ok here a second video, to make it clear :)

http://www.youtube.com/watch?v=I3adpwptvzE&feature=youtu.be

left side is your new modlink version right side is my edited version of your modlink. i did not edit the code but used objects to fix this bug.

— Reply to this email directly or view it on GitHub.

novasnoa commented 10 years ago

cool, if it was fixed it should come out right of the first modlink script right? the secound one is for communication with monomodular and has no meaning for the modlink functionality right?

btw, i recreated your plinko in m4l so i could use it also outside of monomodular, (more and more i work with my own setup) I completely redid it cuz i couldnt figure out your js script :) and i added some nice features, it needs some bugtesting but its closed to finished.

Here are some videos if you are interested :)

Thanks for the great idea behind it!

http://monome.org/community/discussion/17159/plonk-generic-music-box-new-m4l-app#Item_3

robert

2013/12/24 amounra notifications@github.com

Hey, thanks for this….I think I actually did fix it, I'm not sure what's going on, but I'll check and get back to you if I need further help. Appreciated :)

a

On Dec 21, 2013, at 9:09 AM, novasnoa notifications@github.com wrote:

ok here a second video, to make it clear :)

http://www.youtube.com/watch?v=I3adpwptvzE&feature=youtu.be

left side is your new modlink version right side is my edited version of your modlink. i did not edit the code but used objects to fix this bug.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/aumhaa/monomodular/issues/2#issuecomment-31161581 .

novasnoa commented 10 years ago

and Happy Christmas!!!

2013/12/24 amounra notifications@github.com

Hey, thanks for this….I think I actually did fix it, I'm not sure what's going on, but I'll check and get back to you if I need further help. Appreciated :)

a

On Dec 21, 2013, at 9:09 AM, novasnoa notifications@github.com wrote:

ok here a second video, to make it clear :)

http://www.youtube.com/watch?v=I3adpwptvzE&feature=youtu.be

left side is your new modlink version right side is my edited version of your modlink. i did not edit the code but used objects to fix this bug.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/aumhaa/monomodular/issues/2#issuecomment-31161581 .

aumhaa commented 10 years ago

Impressive….that's a lot of work! I dig the demos, inspiring….I'm going to play with Plinko tonight hehe.

Y'know, that was like my first Javascript patch ever, so even if you knew how to write in js, it's not that easy to figure out what's going on.

Re:modLink. The current version is in the "final unfrozen" patches folder, I'm only adding stuff to that atm. Frozen patches are giving me a real headache, so I'm only going to freeze them for full releases. As soon as I get everything working for the rest of the patches, I'm going to remove all the rest from the repo. I know its confusing as hell….

Happy Xmas!

a

On Dec 24, 2013, at 8:51 AM, novasnoa notifications@github.com wrote:

and Happy Christmas!!!

2013/12/24 amounra notifications@github.com

Hey, thanks for this….I think I actually did fix it, I'm not sure what's going on, but I'll check and get back to you if I need further help. Appreciated :)

a

On Dec 21, 2013, at 9:09 AM, novasnoa notifications@github.com wrote:

ok here a second video, to make it clear :)

http://www.youtube.com/watch?v=I3adpwptvzE&feature=youtu.be

left side is your new modlink version right side is my edited version of your modlink. i did not edit the code but used objects to fix this bug.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/aumhaa/monomodular/issues/2#issuecomment-31161581 .

— Reply to this email directly or view it on GitHub.

novasnoa commented 10 years ago

Hey amounra, i just copied the new version of the script (this one which says it solved the bugs) into the modlink and it works fine on rows but columns it doesn't, the 0 0 255 255 message lights the first 8 leds of col 1 and the first 8 leds of col 8 instead of all the 16 leds of col 1.

also i realized that the all message doesnt affect the leds of row 16 and coloumn 16.

sorry for being so pushy but i guess you also want to get rid of those bugs :)

aumhaa commented 10 years ago

Yes, I do! Thanks for the heads up, I'll have a look at it today!

a

On Dec 29, 2013, at 10:24 AM, novasnoa wrote:

Hey amounra, i just copied the new version of the script (this one which says it solved the bugs) into the modlink and it works fine on rows but columns it doesn't, the 0 0 255 255 message lights the first 8 leds of col 1 and the first 8 leds of col 8 instead of all the 16 leds of col 1.

also i realized that the all message doesnt affect the leds of row 16 and coloumn 16.

sorry for being so pushy but i guess you also want to get rid of those bugs :)

— Reply to this email directly or view it on GitHub.

aumhaa commented 10 years ago

Found problem, updated git. Let me know if you find anything else.

BTW, I fixed the file structure, there is now an unfrozen version of modlink.amxd in the "final_unfrozen" folder, I thought I'd already done that.....I also added some testing stuff in there.

Shame you aren't javascript literate....I just built a new version of Plinko. After watching your vids on your version, I decided i wanted to play with it a bit, and immediately realized why I haven't updated it (or used it much) in a while. I started using Java for its engine b/c I couldn't get things fast enough in native Max to my liking, but that made it hard to make changes (I don't know Java that well....javascript, yes...Java, not so much). Anyway, after tinkering with it a bit, I decided to completely rewrite it from scratch again. I did it with a poly~, and its pretty fast. I've only built it for b996 at the moment, but I'll port it back to b995 before I do the final b995 release (hopefully in the next week or so). Anyway, just wanted to thank you for giving me a kick in the rear....it's nice to have access to so many new features that I'd been missing and wanted to include, like copy and trigger modes, as well as better display and programming. Can't wait to finish it!

a

On Dec 29, 2013, at 10:24 AM, novasnoa wrote:

Hey amounra, i just copied the new version of the script (this one which says it solved the bugs) into the modlink and it works fine on rows but columns it doesn't, the 0 0 255 255 message lights the first 8 leds of col 1 and the first 8 leds of col 8 instead of all the 16 leds of col 1.

also i realized that the all message doesnt affect the leds of row 16 and coloumn 16.

sorry for being so pushy but i guess you also want to get rid of those bugs :)

— Reply to this email directly or view it on GitHub.

novasnoa commented 10 years ago

sounds great, i will test it later. I guess if i keep on doing what i do atm ill have to learn some propper language soon. :) Still nice to become more and more indipendent of the work of other great programmers like you and be able to realize my ideas on my own.

As for Plinko, i have made some adjustments too, maybe you like some of the ideas.

You can set now the velocity and the length to each event on each plane. The four quadrants of the monome are four individual "playgrounds" which have acsess to the same sounds and stuff can have their own speed and loop length (birthrate of the traveling tiles) though. The whole thing with the automatic modulation of the scale each time a fourth plane is hit is very nice (at least for my taste)

the fourth quadrant of the monome is not following those modulations and is much more ment to be for drums.