Closed mchangrh closed 1 year ago
Hi, great work!
I noticed both actions tag the image like this:
tags: |
type-raw,value=beta
flavor: |
latest=true
tags: |
type-raw,value=${{ github.ref_name }}
flavor: |
latest=true
Will the newest release image also be tagged with latest
? The beta image just needs beta.
Also, is registry: ghcr.io
the GitHub image registry?
Oops, that must've been an error while copying between the two files.
And yes ghcr.io is the github container registry, I use it for testing since docker won't let me create any more PATs 😅
Forgive me, as I am not that experienced with GitHub pull requests.
Can you alter the PR to tag the images correctly? Also, GitHub secrets' names can't start with GitHub
the GITHUB_TOKEN is taken from the action CI runner automatically https://docs.github.com/en/actions/security-guides/automatic-token-authentication as is ref_name https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables
Ahh, okay. Thank you
originally for #47 closes #55
i386 was excluded since I could not get it to compile without misc go errors