aunetx / blur-my-shell

Extension that adds a blur look to different parts of the GNOME Shell, including the top panel, dash and overview
https://extensions.gnome.org/extension/3193/blur-my-shell/
GNU General Public License v3.0
1.58k stars 88 forks source link

Corners Artifacts in Folders View in Gnome 42 #200

Closed theodormoroianu closed 2 years ago

theodormoroianu commented 2 years ago

The folder icons in the Gnome Shell have grey artifacts around the corners: image

Without the extension no artifacts ar visible (probably because they have the same color as the background): image

Blur-my-shell version: 28 Gnome version: 42.beta OS: Fedora 36 Workstation Edition Prerelease

retrixe commented 2 years ago

This occurs to me on Fedora 36 Prerelease as well. Editing stylesheet.css by commenting

.blurred-overview .app-folder {
    background-color: rgba(0, 0, 0, 0.12);
}

out fixes this issue, like so:

/* .blurred-overview .app-folder {
    background-color: rgba(0, 0, 0, 0.12);
} */

image

I'm not sure if this causes a problem on 40 or 41, though.

theodormoroianu commented 2 years ago

This solved my issue, thanks a lot!

aunetx commented 2 years ago

Thanks a lot, fixed! I may wait some days before pushing to extensions.gnome.org, to bring other fixes with this too :)

retrixe commented 2 years ago

I asked a friend of mine to test a few days ago if this causes an issue on his GNOME 40/41 system and he said the app folder background turns solid like so:

Perhaps load the fix conditionally if running on GNOME 42? I'm not sure how to load stylesheets conditionally, but I guess another way would be attach your own class to .blurred-overview .app-folder items if the user is on GNOME 40/41? Else the extension won't work correctly on those versions anymore.

theodormoroianu commented 2 years ago

The border radius of the folder widgets seems to be 16px, so I think another backwards-compatible way to fix the issue would be to specify a border-radius in the .app-folder class, so that it matches perfectly with the gnome widget.

This styling works for me, and shouldn't change the behavior of the extension on Gnome 40/41:

.blurred-overview .app-folder {
    background-color: rgba(0, 0, 0, 0.12);
    border-radius: 16px;
}

The issue is closed, so pinging @aunetx so that you can see this thread.

aunetx commented 2 years ago

@theodormoroianu thanks a lot, I will see about this soon!