search

aunetx / blur-my-shell

Extension that adds a blur look to different parts of the GNOME Shell, including the top panel, dash and overview
https://extensions.gnome.org/extension/3193/blur-my-shell/
GNU General Public License v3.0
1.58k stars 87 forks source link

Blur My Shell not compatible with prefer-light setting #501

Open acerspyro opened 1 year ago

acerspyro commented 1 year ago

When org.gnome.desktop.interface.color-scheme is set to prefer-light, the top panel becomes illegible on most backgrounds.

image

This is technically an experimental feature in GNOME, but I wanted to give you a heads up as we added a toggle for it in our Toggle project, the replacement for GNOME Tweaks, and people might find that the feature is broken with blur-my-shell.

The immediate solution I see is to add a 30% opacity white background of the colour specified by the shell (it's an eggshell off-white) on top of the blurred wallpaper to guarantee legibility.

image

Another solution would be to force the top panel text to be the colour used in "prefer-dark" mode (current default), so the top bar will have white text, but the rest of the UI components will have black text on a white background.

aunetx commented 1 year ago

Hello, and thanks for the heads up! Could you try the latest commits from github?

I added this feature very recently (which forces the text to be white on the panel), so that changes the light theme but a least everything stays legible :)

The other option for this would be to use the colour effect with a translucent white colour and 0 noise (which is the option you described, so it is already nearly implemented).

I'm thinking about enabling the first option by default, which would change nothing for users of the default theme and prevent light theme users to have any issue; however this could be detrimental to people using other themes because it would require them to disable the option in BmS preferences.

Maybe enabling it automatically if the theme is gnome-shell's light theme? But I don't know how to do it reliably and that could be cumbersome if users change theme regularly, because I don't want to affect their workflow by making them change the option all the time if it's enabled automatically and they don't want it... So I think just enabling it by default would be enough, and people who use other themes will have to disable it! Tell me what you think about it

mityax commented 4 months ago

The "force light text" option is problematic if one has gnome shell's light theme enabled and has enabled "Override Background → Disable when window is near" in Blur My Shell's settings:

Screenshot from 2024-07-12 13-02-55

Is there any way to have the text switch between dark and light depending on whether the panel currently is transparent?