fix: don't restore patched prototypes when suspending

aunetx / blur-my-shell

Extension that adds a blur look to different parts of the GNOME Shell, including the top panel, dash and overview

https://extensions.gnome.org/extension/3193/blur-my-shell/

GNU General Public License v3.0

1.58k stars 88 forks source link

fix: don't restore patched prototypes when suspending #588

Closed flexagoon closed 6 months ago

flexagoon commented 6 months ago

Patched prototypes should only be restored in the disable() method of the extension, since gnome enforces extension rebasing when disabling them. Restoring protos in any other place may lead to infinite recursion if a different extension is also patching the same function.

See https://gitlab.gnome.org/ewlsh/gjs-guide/-/issues/75, https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7629

Fixes: #585

aunetx commented 6 months ago

Thanks a lot! I would not have found it :)

flexagoon commented 6 months ago

@aunetx when will the next version be released? This is a blocking issue for rounded window corners.