search

aunetx / blur-my-shell

Extension that adds a blur look to different parts of the GNOME Shell, including the top panel, dash and overview
https://extensions.gnome.org/extension/3193/blur-my-shell/
GNU General Public License v3.0
1.59k stars 87 forks source link

Extension stops working: this.monitor is null #74

Closed Razer0123 closed 3 years ago

Razer0123 commented 3 years ago

Seems to be related to locking the screen

https://file.io/jyzq3Pzk2RVd

Also happens to some other extensions

CorvetteCole commented 3 years ago

"The file you requested has been deleted". We would also love to get some logs from journalctl from when the problem occurs. You can run journalctl -f (shows a live log) then recreate the issue to get any related errors or logs

Razer0123 commented 3 years ago

Here it is

https://gofile.io/d/HUfc22

Not sure i can recreate the issue, since it does not happen every time i lock the screen, but i will try

CorvetteCole commented 3 years ago

Here I'll attach that file in to git (btw you can drag text files and image files etc in to the text box in the future) dump-of-journalctl.txt

Are you talking about this?

mag 12 23:45:19 archlinux gnome-shell[773]: JS ERROR: Extension dash-to-panel@jderose9.github.com: TypeError: this.monitor is null
                                            getPosition@/home/alessandro/.local/share/gnome-shell/extensions/dash-to-panel@jderose9.github.com/panel.js:488:24
                                            _init@/home/alessandro/.local/share/gnome-shell/extensions/dash-to-panel@jderose9.github.com/panel.js:104:29
                                            _createPanel@/home/alessandro/.local/share/gnome-shell/extensions/dash-to-panel@jderose9.github.com/panelManager.js:397:17
                                            enable@/home/alessandro/.local/share/gnome-shell/extensions/dash-to-panel@jderose9.github.com/panelManager.js:84:34
                                            _enable@/home/alessandro/.local/share/gnome-shell/extensions/dash-to-panel@jderose9.github.com/extension.js:104:18
                                            enable@/home/alessandro/.local/share/gnome-shell/extensions/dash-to-panel@jderose9.github.com/extension.js:66:5
                                            _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:167:32
                                            _enableAllExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:601:22
                                            _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:600:37
                                            _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:628:18
                                            _emit@resource:///org/gnome/gjs/modules/core/_signals.js:114:47
                                            _sync@resource:///org/gnome/shell/ui/sessionMode.js:197:14
                                            popMode@resource:///org/gnome/shell/ui/sessionMode.js:165:14
                                            _continueDeactivate@resource:///org/gnome/shell/ui/screenShield.js:518:30
                                            deactivate/<@resource:///org/gnome/shell/ui/screenShield.js:509:44
                                            finish@resource:///org/gnome/shell/gdm/authPrompt.js:604:13
                                            finish@resource:///org/gnome/shell/ui/unlockDialog.js:871:26
                                            deactivate@resource:///org/gnome/shell/ui/screenShield.js:509:26
                                            ScreenShield/</<@resource:///org/gnome/shell/ui/screenShield.js:109:57
                                            _emit@resource:///org/gnome/gjs/modules/core/_signals.js:114:47
                                            _convertToNativeSignal@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:152:19

If so, it seems to be a dash-to-panel bug

CorvetteCole commented 3 years ago

oh wait, nevermind all your extensions had that issue. I think this is probably not a blur-my-shell bug in this case, although I'm not sure

CorvetteCole commented 3 years ago

Relevant part of log is below. I think we could add a null check for this but it is not our bug specifically

mag 12 23:45:19 archlinux gnome-shell[773]: [Blur my Shell] enabling extension...
mag 12 23:45:19 archlinux gnome-shell[773]: JS ERROR: Extension blur-my-shell@aunetx: TypeError: this.monitor is null
                                            PanelBlur@/home/alessandro/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/panel.js:28:13
                                            enable@/home/alessandro/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/extension.js:25:28
                                            _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:167:32
                                            _enableAllExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:601:22
                                            _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:600:37
                                            _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:628:18
                                            _emit@resource:///org/gnome/gjs/modules/core/_signals.js:114:47
                                            _sync@resource:///org/gnome/shell/ui/sessionMode.js:197:14
                                            popMode@resource:///org/gnome/shell/ui/sessionMode.js:165:14
                                            _continueDeactivate@resource:///org/gnome/shell/ui/screenShield.js:518:30
                                            deactivate/<@resource:///org/gnome/shell/ui/screenShield.js:509:44
                                            finish@resource:///org/gnome/shell/gdm/authPrompt.js:604:13
                                            finish@resource:///org/gnome/shell/ui/unlockDialog.js:871:26
                                            deactivate@resource:///org/gnome/shell/ui/screenShield.js:509:26
                                            ScreenShield/</<@resource:///org/gnome/shell/ui/screenShield.js:109:57
                                            _emit@resource:///org/gnome/gjs/modules/core/_signals.js:114:47
                                            _convertToNativeSignal@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:152:19
mag 12 23:45:19 archlinux gnome-shell[773]: JS WARNING: [/home/alessandro/.local/share/gnome-shell/extensions/just-perfection-desktop@just-perfection/lib/API.js 161]: unreachable code after return statement
mag 12 23:45:19 archlinux gnome-shell[773]: JS ERROR: Extension just-perfection-desktop@just-perfection: TypeError: pMonitor is null
                                            monitorGetInfo@/home/alessandro/.local/share/gnome-shell/extensions/just-perfection-desktop@just-perfection/lib/API.js:1022:13
                                            panelSetPosition@/home/alessandro/.local/share/gnome-shell/extensions/just-perfection-desktop@just-perfection/lib/API.js:1042:32
                                            _applyTopPanelPosition@/home/alessandro/.local/share/gnome-shell/extensions/just-perfection-desktop@just-perfection/lib/Manager.js:603:23
                                            applyAll@/home/alessandro/.local/share/gnome-shell/extensions/just-perfection-desktop@just-perfection/lib/Manager.js:186:14
                                            enable@/home/alessandro/.local/share/gnome-shell/extensions/just-perfection-desktop@just-perfection/extension.js:54:13
                                            _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:167:32
                                            _enableAllExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:601:22
                                            _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:600:37
                                            _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:628:18
                                            _emit@resource:///org/gnome/gjs/modules/core/_signals.js:114:47
                                            _sync@resource:///org/gnome/shell/ui/sessionMode.js:197:14
                                            popMode@resource:///org/gnome/shell/ui/sessionMode.js:165:14
                                            _continueDeactivate@resource:///org/gnome/shell/ui/screenShield.js:518:30
                                            deactivate/<@resource:///org/gnome/shell/ui/screenShield.js:509:44
                                            finish@resource:///org/gnome/shell/gdm/authPrompt.js:604:13
                                            finish@resource:///org/gnome/shell/ui/unlockDialog.js:871:26
                                            deactivate@resource:///org/gnome/shell/ui/screenShield.js:509:26
                                            ScreenShield/</<@resource:///org/gnome/shell/ui/screenShield.js:109:57
                                            _emit@resource:///org/gnome/gjs/modules/core/_signals.js:114:47
                                            _convertToNativeSignal@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:152:19
mag 12 23:45:19 archlinux gnome-shell[773]: Timelines with detached actors are not supported
mag 12 23:45:19 archlinux gnome-shell[773]: Timelines with detached actors are not supported
mag 12 23:45:19 archlinux gnome-shell[773]: Timelines with detached actors are not supported
mag 12 23:45:19 archlinux gnome-shell[773]: Timelines with detached actors are not supported
mag 12 23:45:19 archlinux gnome-shell[773]: Timelines with detached actors are not supported
mag 12 23:45:19 archlinux gnome-shell[773]: Timelines with detached actors are not supported
mag 12 23:45:19 archlinux gnome-shell[773]: Timelines with detached actors are not supported
mag 12 23:45:19 archlinux gnome-shell[773]: Timelines with detached actors are not supported
mag 12 23:45:19 archlinux gnome-shell[773]: Timelines with detached actors are not supported
mag 12 23:45:19 archlinux gnome-shell[773]: Timelines with detached actors are not supported
mag 12 23:45:19 archlinux gnome-shell[773]: Timelines with detached actors are not supported
mag 12 23:45:19 archlinux gnome-shell[773]: Timelines with detached actors are not supported
mag 12 23:45:19 archlinux gnome-shell[773]: Timelines with detached actors are not supported
mag 12 23:45:19 archlinux gnome-shell[773]: Timelines with detached actors are not supported
mag 12 23:45:19 archlinux gnome-shell[773]: JS ERROR: Extension dash-to-panel@jderose9.github.com: TypeError: this.monitor is null
                                            getPosition@/home/alessandro/.local/share/gnome-shell/extensions/dash-to-panel@jderose9.github.com/panel.js:488:24
                                            _init@/home/alessandro/.local/share/gnome-shell/extensions/dash-to-panel@jderose9.github.com/panel.js:104:29
                                            _createPanel@/home/alessandro/.local/share/gnome-shell/extensions/dash-to-panel@jderose9.github.com/panelManager.js:397:17
                                            enable@/home/alessandro/.local/share/gnome-shell/extensions/dash-to-panel@jderose9.github.com/panelManager.js:84:34
                                            _enable@/home/alessandro/.local/share/gnome-shell/extensions/dash-to-panel@jderose9.github.com/extension.js:104:18
                                            enable@/home/alessandro/.local/share/gnome-shell/extensions/dash-to-panel@jderose9.github.com/extension.js:66:5
                                            _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:167:32
                                            _enableAllExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:601:22
                                            _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:600:37
                                            _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:628:18
                                            _emit@resource:///org/gnome/gjs/modules/core/_signals.js:114:47
                                            _sync@resource:///org/gnome/shell/ui/sessionMode.js:197:14
                                            popMode@resource:///org/gnome/shell/ui/sessionMode.js:165:14
                                            _continueDeactivate@resource:///org/gnome/shell/ui/screenShield.js:518:30
                                            deactivate/<@resource:///org/gnome/shell/ui/screenShield.js:509:44
                                            finish@resource:///org/gnome/shell/gdm/authPrompt.js:604:13
                                            finish@resource:///org/gnome/shell/ui/unlockDialog.js:871:26
                                            deactivate@resource:///org/gnome/shell/ui/screenShield.js:509:26
                                            ScreenShield/</<@resource:///org/gnome/shell/ui/screenShield.js:109:57
                                            _emit@resource:///org/gnome/gjs/modules/core/_signals.js:114:47
                                            _convertToNativeSignal@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:152:19
Razer0123 commented 3 years ago

If you could fix it I would really appreciate it, at the moment I have to restart gnome twice a day :/

CorvetteCole commented 3 years ago

@Razer0123 this problem is impacting all of your extensions, there is some sort of configuration issue or bug with gnome she'll which is why this is happening. We aren't gonna be able to "fix" this per SE, the solution would be graceful failing so it doesn't crash the extension (but that part of the code wouldn't work). I assume your other extensions that have this issue aren't working either, right?

If you tell me what gnome-shell version you are running, your monitor setups, x11 or Wayland, your GPU I can try and see if I can find a related upstream bug to help you fix this

aunetx commented 3 years ago

Could you give me the result of Main.layoutManager.primaryMonitor in looking glass (alt+f2, lg)?

If the result is null or something like that, this definitively is not a bug from Blur my Shell...

Razer0123 commented 3 years ago

@Razer0123 this problem is impacting all of your extensions, there is some sort of configuration issue or bug with gnome she'll which is why this is happening. We aren't gonna be able to "fix" this per SE, the solution would be graceful failing so it doesn't crash the extension (but that part of the code wouldn't work). I assume your other extensions that have this issue aren't working either, right?

If you tell me what gnome-shell version you are running, your monitor setups, x11 or Wayland, your GPU I can try and see if I can find a related upstream bug to help you fix this

Yes but happens only on 3 extensions

Just updated to Gnome shell 40.1 (not sure if it will happen again, i was on 40.0.1), Xorg, Nvidia gpu

Razer0123 commented 3 years ago

Could you give me the result of Main.layoutManager.primaryMonitor in looking glass (alt+f2, lg)?

If the result is null or something like that, this definitively is not a bug from Blur my Shell...

Sorry i am not sure i understood what to do

aunetx commented 3 years ago

@Razer0123 after opening looking glass (which you can open by pressing alt and f2 at the same time, then typing lg - enter), you can type in the console that was opened: Main.layoutManager.primaryMonitor, and give me the result

Razer0123 commented 3 years ago

This is it IMG_9154

By the way i did not have the issue since updating to 40.1

Razer0123 commented 3 years ago

Happened again today

aunetx commented 3 years ago

Honestly, I don't have any idea what it could be caused by... Could you give me the result of the command I gave now, if it worked before?

aunetx commented 3 years ago

I close this, as it does not seem to come from Blur my Shell and I can't reproduce it...

If it still happens, please tell me and I will try to force BmS not to crash when it encounter this issue, but I'm not sure about it right now, as it could disable silently an important part of Blur my Shell in case of crash for some users, and I don't know how I could continue without even having a monitor object...

aunetx commented 3 years ago

Wait no, are you using an external screen? I think I understand where this could come from

Razer0123 commented 3 years ago

Hello sorry for the delay, yes i am using an external screen, this is the error i am getting now

lug 07 12:24:59 desktop gnome-shell[1907]: JS ERROR: Extension blur-my-shell@aunetx: TypeError: this.mainDock is null
                                           get@/usr/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/docking.js:1766:1
                                           disable@/home/alessandro/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/dash.js:32:13
                                           disable@/home/alessandro/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/extension.js:63:25
                                           _callExtensionDisable@resource:///org/gnome/shell/ui/extensionSystem.js:108:32
                                           _disableAllExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:613:22
                                           _disableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:612:52
                                           _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:630:18
                                           _emit@resource:///org/gnome/gjs/modules/core/_signals.js:114:47
                                           _sync@resource:///org/gnome/shell/ui/sessionMode.js:197:14
                                           pushMode@resource:///org/gnome/shell/ui/sessionMode.js:158:14
                                           activate@resource:///org/gnome/shell/ui/screenShield.js:590:34
                                           lock@resource:///org/gnome/shell/ui/screenShield.js:634:14
                                           LockAsync@resource:///org/gnome/shell/ui/shellDBus.js:382:28
jrahmatzadeh commented 3 years ago

Primary monitor will be null when there isn't any display. In that case you should check the value, the extension will crash otherwise. I've fixed the pMonitor bug on my extension before. It's not on the ggo yet.

Razer0123 commented 3 years ago

Also seems not to happen when Dash to Dock is disabled

EDIT: Now enabled Dash to Panel and this happened

lug 07 14:17:22 desktop gnome-shell[1907]: JS ERROR: Extension blur-my-shell@aunetx: TypeError: this.monitor is null PanelBlur@/home/alessandro/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/panel.js:31:13 enable@/home/alessandro/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/extension.js:28:28 _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:167:32 _enableAllExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:601:22 _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:600:37 _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:628:18 _emit@resource:///org/gnome/gjs/modules/core/_signals.js:114:47 _sync@resource:///org/gnome/shell/ui/sessionMode.js:197:14 popMode@resource:///org/gnome/shell/ui/sessionMode.js:165:14 _continueDeactivate@resource:///org/gnome/shell/ui/screenShield.js:518:30 deactivate/<@resource:///org/gnome/shell/ui/screenShield.js:509:44 finish@resource:///org/gnome/shell/gdm/authPrompt.js:604:13 finish@resource:///org/gnome/shell/ui/unlockDialog.js:871:26 deactivate@resource:///org/gnome/shell/ui/screenShield.js:509:26 injections_add/<@/usr/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:471:30 ScreenShield/</<@resource:///org/gnome/shell/ui/screenShield.js:109:57 _emit@resource:///org/gnome/gjs/modules/core/_signals.js:114:47 _convertToNativeSignal@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:152:19

aunetx commented 3 years ago

Sorry for closing, did the latest commit fix this?

Razer0123 commented 3 years ago

Hello, since i had issues with several extensions i ended up disabling the Dash and moving to Plank

Will try to test in the next few days

aunetx commented 3 years ago

Ok thanks!

aunetx commented 3 years ago

I pushed the fix on extensions.gnome.org, if after updating it the issue still exists, please reopen the issue!