aunetx / deezer-linux

An universal linux port of deezer, supporting Flatpak, Appimage, Snap, RPM, DEB...
https://flathub.org/apps/dev.aunetx.deezer
288 stars 14 forks source link

Album in track metadata is empty #17

Open joerg65 opened 2 years ago

joerg65 commented 2 years ago

I try to get metadata with playerctl, there is song title and artist, but album stays empty.

playerctl metadata
chromium xesam:album               
chromium xesam:artist              Some Artist
chromium xesam:title               Some Title

As I have seen it is processed here in renderer.js:

                  track = {
                    title:
                      song.SNG_TITLE ||
                      song.LIVESTREAM_TITLE ||
                      song.EPISODE_TITLE ||
                      "",
                    artist:
                      song.ART_NAME ||
                      song.LIVESTREAM_TITLE ||
                      song.SHOW_NAME ||
                      "",
                    album: song.ALB_TITLE,
                    coverUrl: defaultCover,
                  },

Any idea how to solve? Note that I have compiled from source, but I don't have experience in js or node.

aunetx commented 2 years ago

Thank you for the report!

Unfortunately I don't have much control over MPRIS, but I may find something by playing around with this part of the code :)

faelau commented 2 years ago

Hello!

Maybe this patchh can help you: https://github.com/daltroaugusto/deezer-void/blob/master/patches/0001-MPRIS-interface.patch This way we should also get an working album art!

aunetx commented 2 years ago

Hello!

Maybe this patchh can help you: https://github.com/daltroaugusto/deezer-void/blob/master/patches/0001-MPRIS-interface.patch This way we should also get an working album art!

Thank you very much! However this patch does not work anymore, as if I understood correctly Deezer got ride of the mpris library and I can't use this anymore... However I will see if I can copy some of its behaviour :)

aunetx commented 2 years ago

That's infeasible on my end... I really don't understand anything of the player itself (because it is all a blob compressed and minified js mess), and the electron server part does not seem to have access to the MPRIS part anymore.

Honestly, we will need some kind of "official" support before this could be done, imho...