search

aunetx / deezer-linux

An universal linux port of deezer, supporting Flatpak, Appimage, Snap, RPM, DEB...
https://flathub.org/apps/dev.aunetx.deezer
288 stars 14 forks source link

Fix mime type #20

Closed adynemo closed 2 years ago

adynemo commented 2 years ago

Hello ! 🙂

This patch fixes #13 After several searches, the xdg-settings bug is still not resolved: https://gitlab.freedesktop.org/xdg/xdg-utils/-/issues/180 And finally, I don't know if update electron version could solve anything. As explain here https://github.com/lbryio/lbry-desktop/pull/5617 the bug appears when we call setAsDefaultProtocolClient on Linux. There is the concerned lines on xdg-utils issue. Signal has change the production name and remove the dash from the desktop file signal-desktop.desktop to signal.desktop but for some app, like deezer-linux, it seems to not work. So, I've chosen the LBRY way that avoid the call to this function if the platform is linux. As deezer-linux is only for linux, I don't put the condition, but we can.

I tested with the deb build and all works (start app, login via browser, listen music, etc).

aunetx commented 2 years ago

Hello @adynemo, and thank you very very much for the time you spent understanding and improving this!

I tried this and it actually seems to work, that's great thank you! I merge this right now and this will be included in next update :)