search

aungkoko1234 / web-scrapper-backend

A Web Scrapper for google search results with keyword
0 stars 0 forks source link

[Question] Why does the application need some redundant API #16

Open longnd opened 1 year ago

longnd commented 1 year ago

Issue

The backend application provides some redundant API, e.g. the API to Get User List. Taking into account that API is not required by the code challenge requirements - is it needed somewhere?

aungkoko1234 commented 1 year ago

Yeah, the user listing is not required in assignment. It has no UI in frontend. So do I need to remove ?

longnd commented 1 year ago

it is not needed to removed, but may I know why you decided to implement that API?

also, there is an API to create individual keyword https://github.com/aungkoko1234/web-scrapper-backend/blob/9c520dc93598646fcc0f72d54845ec7a2838a985/src/keywords/keywords.controller.ts#L57-L71

where is it intended to use?

aungkoko1234 commented 1 year ago

At first , I implemented the keyword searching with single keyword for testing and check it is working or not. And then I implemented the csv upload with multiple searching.

longnd commented 1 year ago

besides the API_URL env variable, is there any other environment variable I need to set for the front-end app? 🤔

aungkoko1234 commented 1 year ago

I will update soon in frontend repo