search

aungkoko1234 / web-scrapper-backend

A Web Scrapper for google search results with keyword
0 stars 0 forks source link

[Question] Redundant methods #18

Open longnd opened 1 year ago

longnd commented 1 year ago

Issue

The Helper has several unused methods, for example, https://github.com/aungkoko1234/web-scrapper-backend/blob/9c520dc93598646fcc0f72d54845ec7a2838a985/src/helpers/helpers.service.ts#L39

https://github.com/aungkoko1234/web-scrapper-backend/blob/9c520dc93598646fcc0f72d54845ec7a2838a985/src/helpers/helpers.service.ts#L72

they're irrelevant to the context of this small application. Are they being used somewhere?

aungkoko1234 commented 1 year ago

Yeah they are not necessary. I forgot to remove those after I tested. I will remove those.

longnd commented 1 year ago

may I know why the application needs those functions and why did you need to test them?

aungkoko1234 commented 1 year ago

For image delete function, I intended to delete the csv file after the queue for searching keyword is complete. Even though the naming is wrong.

aungkoko1234 commented 1 year ago

@longnd I have removed those redundant methods.