[Chore] Naming improvement - Githubissues

aungkoko1234 / web-scrapper-backend

A Web Scrapper for google search results with keyword

0 stars 0 forks source link

[Chore] Naming improvement #19

Open longnd opened 1 year ago

longnd commented 1 year ago

Issue

Some functions' name does not match with what they actually do, for example

The function to get keyword lists is named as getUsers https://github.com/aungkoko1234/web-scrapper-backend/blob/9c520dc93598646fcc0f72d54845ec7a2838a985/src/keywords/keywords.controller.ts#L39-L42
The functions to upload CSV file are named as uploadImage & uploadImageToS3 https://github.com/aungkoko1234/web-scrapper-backend/blob/9c520dc93598646fcc0f72d54845ec7a2838a985/src/keywords/keywords.controller.ts#L74-L83
The function to process keyword searching is named as handleSyncMoodNote which is irrelevant https://github.com/aungkoko1234/web-scrapper-backend/blob/9c520dc93598646fcc0f72d54845ec7a2838a985/src/keywords/keywords.processor.ts#L19-L22

The function to handle CSV file upload to S3 treat the file as image, e.g. there is even the imageBucket used https://github.com/aungkoko1234/web-scrapper-backend/blob/9c520dc93598646fcc0f72d54845ec7a2838a985/src/helpers/helpers.service.ts#L15-L22

Expected

Proper name for functions & variables

aungkoko1234 commented 1 year ago

Yeah, that s right.Function and variables name should be declared properly. My bad.