[Chore] The helperService is reponsible for too many reponsibilities

aungkoko1234 / web-scrapper-backend

A Web Scrapper for google search results with keyword

0 stars 0 forks source link

[Chore] The helperService is reponsible for too many reponsibilities #22

Open longnd opened 1 year ago

longnd commented 1 year ago

Issue

The application is overusing the HelperService, it is responsible for

Upload file to S3
Delete file from S3
Stream file from S3
Search the keyword on Google

Those are irrelevant domains. If it is really needed to upload the file to S3, isn't it better to have a service just for S3 operations purposes and another service for crawling the result from Google, e.g. a Scraper service?

aungkoko1234 commented 1 year ago

I should separate the searching related functions as an another service like you said Scraper service.

longnd commented 1 year ago

may I know why you still prefer to using a generic service (HelperService) to handle solely the S3 file operation (upload & stream), even that PR #26 ?