search

aupac / ember-aupac-typeahead

ember-cli ajax typeahead search component
MIT License
25 stars 38 forks source link

Dependency on typeahead.js #45

Closed snewcomer closed 7 years ago

snewcomer commented 7 years ago

Any thoughts on trying to integrate https://github.com/corejavascript/typeahead.js/ instead of what looks like the no longer maintained version of it?

theseyi commented 7 years ago

I agree with this, there are several issues with the no longer maintained version of Twitter's typeahead, including https://github.com/twitter/typeahead.js/issues/1232 which has several PR's that are still open including the issue itself.

jackmatt2 commented 7 years ago

Yep, can't see any issues with this. Will accept a pull request updating the dependency assuming all tests pass.

On 5 Apr 2017 7:30 a.m., "Seyi Adebajo" notifications@github.com wrote:

I agree with this, there are several issues with the no longer maintained version of Twitter's typeahead, including twitter/typeahead.js#1232 https://github.com/twitter/typeahead.js/issues/1232 which has several PR's that are still open including the issue itself.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aupac/ember-aupac-typeahead/issues/45#issuecomment-291637772, or mute the thread https://github.com/notifications/unsubscribe-auth/AGDdOHRN1CI-U7uujN3_KjaajGXbSOa2ks5rsrZ6gaJpZM4MyPf_ .

theseyi commented 7 years ago

@jackmatt2 will do in a minute

jackmatt2 commented 7 years ago

Resolved via #46