Closed krisnova closed 1 year ago
CC @dmah42
which branch are you working on that has the TODOs?
i think i found it on main
there are some nuances here that i'd like to get clarity on:
PodSandbox
with lower level Container
objects. right now, the thing called a "sandbox" is actually a Container
. so should the cache be at the container level or the pod sandbox level?libcontainer::container
and aurae_proto::cri
, which define things like ContainerStatus
for example. should we be mapping between them or is this unexpected?@dmah42 hopefully you saw my comment: https://github.com/aurae-runtime/aurae/pull/388#discussion_r1103509601
I might push some changes to your branch today if i can find the time/energy
Right now the CRI service code is blocked on adding a caching mechanism to the code base (similar to what we have done with cells).
Can we please add the get/set cache code into the
cri_service.rs
file in place of the existing todo's?For example in order for us to stop a pod sandbox:
We need to first have the cached pod sandbox available, then we can call
sandbox.kill()
on the item retrieved from the cache.