refactor: simple anyhow error handling

aurae-runtime / auraed

Secure mTLS and gRPC backed runtime daemon. Alternative to systemd. Written in Rust.

https://aurae.io/auraed

Apache License 2.0

60 stars 11 forks source link

refactor: simple anyhow error handling #38

Closed Vincinator closed 1 year ago

Vincinator commented 1 year ago

Hi @future-highway, could you review this PR please?

This PR iterates over the error handling of the init module.

added Err return values in cases where we silently failed before
use expect instead of unwrap
restrict function visibility of init functions to a minimum, to help maintain and select appropriate error handling

Next iteration on error handling could be the introduction of custom error types. see: https://github.com/aurae-runtime/auraed/issues/32

Vincinator commented 1 year ago

Thank you, I enjoy your nice reviews @future-highway. If you are happy with the changes and want to merge, could you select "squash and merge" please?