search

aurajs / aura

A scalable, event-driven JavaScript architecture for developing component-based applications.
MIT License
2.94k stars 255 forks source link

resolve name conflict on node-webkit #311

Open yapcheahshen opened 11 years ago

yapcheahshen commented 11 years ago

use requirejs() instead of require() for running on node-webkit.

sbellity commented 11 years ago

@yapcheahshen the tests seem to fail.

https://travis-ci.org/aurajs/aura/jobs/11012559

Can you fix this ?

Thanks !

sbellity commented 11 years ago

@yapcheahshen Very curious to see it running on node-webkit ! Do you have a demo to share ;) ?

yapcheahshen commented 11 years ago

i built this platform , write and test on node-webkit, and deploy to server right away. https://github.com/yapcheahshen/ksanapc

On Thu, Sep 5, 2013 at 7:54 PM, Stephane Bellity notifications@github.comwrote:

@yapcheahshen https://github.com/yapcheahshen Very curious to see it running on node-webkit ! Do you have a demo to share ;) ?

— Reply to this email directly or view it on GitHubhttps://github.com/aurajs/aura/pull/311#issuecomment-23862239 .

yapcheahshen commented 11 years ago

it seems like https://travis-ci.org/aurajs/aura/jobs/11012559 doesn't have "requirejs" I am using RequireJS 2.0.2 with node-webkit, on node-webkit, require() is node.js CommonJS , on browser side need to use requirejs() for AMD.