Harmonizes init of app.logger and sandbox.logger

aurajs / aura

A scalable, event-driven JavaScript architecture for developing component-based applications.

MIT License

2.94k stars 255 forks source link

Harmonizes init of app.logger and sandbox.logger #314

Closed xcambar closed 11 years ago

xcambar commented 11 years ago

The issue that this PR solves is as described:

When passing {debug: {enable: true}} to the Aura constructor, both the loggers attached to the sandboxes and the logger attached to the app would be started.

When passing {debug: true} to the Aura constructor, only the loggers in the sandboxes would be started.

This PR solves this and provides the related specs.

robertd commented 11 years ago

Are we ready to re-tag aura to 0.9.2? Our new additions to API docs and boilerplate (deps on aura@0.9.1) are out of sync.

/cc @addyosmani @sbellity