search

aurajs / aura

A scalable, event-driven JavaScript architecture for developing component-based applications.
MIT License
2.94k stars 255 forks source link

Merge in useful fork #338

Closed svperfecta closed 7 years ago

svperfecta commented 10 years ago

There's lot of fixes here to Aura, many of which I've found useful in my project. I'd love to see them merged in to the master branch. Also, I'd like to see aura development continue, this is a popular project and it hasn't seen much activity in some time.

svperfecta commented 10 years ago

Just a note: I'm hoping this sparks a bit of a conversation, and also a merging of efforts here with @finalprototype. Aura needs to be reinvigorated.

addyosmani commented 10 years ago

Thanks for kickstarting some ideas and fixes around reinvigorating the project. Given the number of changes here, we may need to ask that they be split out into separate PRs, but @sbellity and others may be able to review the change list in it's current state.

Things I would be interested in:

svperfecta commented 10 years ago

Awesome. We just kicked off a big aura project for a well known media company, we're really excited about it! My biggest concern when evaluating aura was the lack of activity, but there seems to be a lot of activity in the two biggest forks; both by teams which have products committed to the library.

I think this project gets so much right in so many ways. We looked at Flight and some others, and this project is a better cohesive whole; it's biggest problem is that it might have been released a little before its time.

Given the recent update to the readme (thanks @addyosmani!) and the stated intention of not only continuing, but of potentially integrating polymer, I'd be happy to help in any way I can to keep things moving.

addyosmani commented 10 years ago

We would appreciate any and all help with revamping the project. My intentions for a future release are to break down Aura into a focused set of Polymer elements you can easily pick and choose, but I think there's plenty we can improve in this version on our road there :)

sbellity commented 10 years ago

Hey @genexp thanks for all those fixes ! Agreed, @aurajs needs to be reinvigorated and I would love to have you guys on board to help us push it forward.

I'll review the PR as soon as possible. Let's keep in touch soon

Pickachu commented 10 years ago

We're using it heavily into two production apps here, and very excited as well. And probably will be using in more future apps. We heavily support the polymer direction of aura.

Also I will give more support and some PR's, but i can't do it right now. In relation to the PR, I found myself doing some of these fixes, and i can see their value. Nice job @genexp and @addyosmani!

Thank you guys for the awesome project!

sbellity commented 10 years ago

@genexp @Pickachu @addyosmani Just a few thoughts :

finalprototype commented 10 years ago

@sbellity Sorry, these are our internal custom tags based on each one of these changes we made. Once we hit a period where we could collaborate and provide a PR back to Aura master, we were gonna sanitize the changes, provide tests and docs, and ensure none of the changes were custom, directly relating to requirements of our working platform.

We're unfortunately still not in a position to do that.

sbellity commented 10 years ago

@finalprototype I would be happy to merge those changes into master. None of them seem to be very specific... What should we do about this PR then ?

addyosmani commented 10 years ago

Just to follow-up on this (whenever you do have time). If we can break down the PRs into more atomic pieces that can be easily reviewed we would be happy to consider merging them in.

addyosmani commented 10 years ago

@sbellity do we still want to try bringing this in?

addyosmani commented 10 years ago

@genexp I've recently been getting pinged by quite a few developers interested in us landing some of the work started in this PR into master. I totally understand that you and your team may not have time to rebase this work. If you do, that would be valuable to the community.

If not, would you be opposed to me cleaning up a cherry-pick of commits that we can land in master to cut an interim release? Our long-term plan is to still refactor Aura into Polymer elements but I think it would be useful to share some of the work you've done to evolve Aura into here. Thoughts?