auraphp / Aura.Di

Dependency Injection System
MIT License
349 stars 63 forks source link

Allow for mutable virtual properties without IDE errors #102

Closed dstockto closed 9 years ago

dstockto commented 9 years ago

Changed @property-read to @property so they will still be auto-completed, but won't complain if you try to modify the values via magic methods.

Addresses the issue #91 concern for 2.x.

Without this patch:

image

Note the squiggly red lines.

With the patch:

image

harikt commented 9 years ago

this is an interesting commit with no files changed. Wondering how this happened.

dstockto commented 9 years ago

That's really weird @harikt - It looked good when I did it and tested in php storm. In any case, I've pushed up the code that I intended to have pushed up. Sorry about that.

harikt commented 9 years ago

no issues. I was just wondering as there was no files changed shown in the commit. not sure how that git commit was made.

dstockto commented 9 years ago

Not sure what happened either. Typically you've got to put --allow-empty on the commit to get an empty commit. In any case, it should be good now.

harikt commented 9 years ago

Thank you @dstockto for the tip. I will wait for @pmjones to merge this.

pmjones commented 9 years ago

Thanks @dstockto !

dstockto commented 9 years ago

You're welcome.