auraphp / Aura.Di

Dependency Injection System
MIT License
349 stars 63 forks source link

fix missed parameter for LazyValue object #132

Closed omniton closed 8 years ago

omniton commented 8 years ago

Hi, I've found that 2.x:$di->LazyValue($array, $key) doesn't work correctly. There is a fix.

harikt commented 8 years ago

@omniton didn't get what you are trying to achieve here. This seems incorrect for me, and you can see the test also is failing.

From the docs : https://github.com/auraphp/Aura.Di/tree/81d5d9c602ca292a16e32001dcbd2adab5350e28#lazy-values

If you still feel there is something missing, lets have a test to show that it is failing.

Thank you.

omniton commented 8 years ago

yeah, It's my fault - I was trying to apply different approach for LazyVal. It's my fault that I didn't check test - there is explanation ho to use it correctly

harikt commented 8 years ago

no problem.

Latest version of Aura.Di is 3.x . You should consider using it.

Thanks!