search

auraphp / Aura.Di

Dependency Injection System
MIT License
349 stars 63 forks source link

Rearranging code to achieve full test coverage with the existing test suite #141

Closed jhoughtelin closed 7 years ago

jhoughtelin commented 7 years ago

According to the contributing guidelines, 100% test coverage should be maintained so this modifies the Reflector class in a manner that is only significant to the test suite to allow the existing test suite to obtain full coverage without any functional change.

Before before

After after

This just nixes a few lines of code and establishes 100% code coverage for the package.

Cheers, Thank you & Happy Holidays.

harikt commented 7 years ago

Probably adding more tests may help to increase coverage. I like some of your ways, but the problem is then it happens to be nested blocks which seems not a good idea.

@pmjones will look more into this and address the same.

pmjones commented 7 years ago

Nice. Thanks for the attention to detail!