Add type hints, PHP7.2+ only, upgrade to phpunit 7

auraphp / Aura.Di

Dependency Injection System

MIT License

349 stars 63 forks source link

Add type hints, PHP7.2+ only, upgrade to phpunit 7 #173

Closed frederikbosch closed 5 years ago

frederikbosch commented 5 years ago

Upgrade to PHP 7.2+ only, strict types enabled
Dropped HHVM support
PHPUnit now @ ^7
Signatures of methods in ContainerConfigInterface changed.
LazyRequire and LazyInclude do not accept another lazy
Remove container interop dependency
Fixes #161, #163, #171 and #166

harikt commented 5 years ago

Great work! :+1: . Basically this should go to 4.x branch.

harikt commented 5 years ago

@frederikbosch I have created a 4.x branch. You can make this PR to 4.x branch. I am also not sure about the future of Aura.Di for there is another container by @pmjones https://github.com/capsulephp/di .

frederikbosch commented 5 years ago

@harikt I changed the base for the PR. Well, I am happy with this container and hopefully can contribute some to it.

harikt commented 5 years ago

Base looks same auraphp:3.x . But I can push it to 4.x merging locally if needed.

frederikbosch commented 5 years ago

Also squashed the commit.