search

auraphp / Aura.Di

Dependency Injection System
MIT License
349 stars 63 forks source link

Bug fixes for optional params (3.x) #180

Closed frederikbosch closed 5 years ago

frederikbosch commented 5 years ago

Fixes #156 and #165

frederikbosch commented 5 years ago

Oh lord, I just pushed a fix for PHP 5.5.

harikt commented 5 years ago

@frederikbosch great! . Just a suggestion, may be good not to merge your own PR's unless it is very urgent or no reviewers show up. Congrats on your first PR merge by the way :dancer:

frederikbosch commented 5 years ago

@harikt Thanks! I won't and definitely not for changes and new features. However, in cases like these I am a little less strict.