Closed niden closed 4 years ago
Hi @niden ,
I am not in favor of certain things.
These are some of my thoughts.
Hey @harikt
Not sure about #1. I always kept directories even empty ones.
Have a look at the actions on my fork: https://github.com/niden/Aura.Di/actions As you will see it is pretty much Travis on GitHub. I can remove it if you like - I started using it more and more so thought that Aura could benefit with one more CI.
Hi @niden ,
No actions need to be taken. Let other members also get a change to look into this.
May be @frederikbosch will respond once he get some time.
@harikt What shall we do with this one? Personally, I rather include PHPStan than the PDS standard.
@frederikbosch both ( PDS and PHPstan) are different tools I believe. I have no objections with what you choose. So full support for your choices :) .
What are these public
and resources
files to do with. I wonder whether those are compulsory for PDS. If so I don't like keeping such ones just for the sake. I am against those.
Sorry, I rather leave things as they are now. More tools means more maintenance. Since the proposed tools do not provide anything to the code, I rather leave them out.
ocular.phar
to thebin
directory to speed things upAdditional PHPCS PR to follow