search

auraphp / Aura.Di

Dependency Injection System
MIT License
349 stars 63 forks source link

Update for modern PHP #192

Closed cxj closed 4 years ago

cxj commented 4 years ago

Updates to make compatible with PHP 7.4 and PHPUnit 8+.

frederikbosch commented 4 years ago

You did not update the require-dev right?

cj-clx commented 4 years ago

@frederikbosch That's correct; I did not. The changes are backward compatible with PHPUnit 7.

frederikbosch commented 4 years ago

For require-dev I think it is fine to just move to the latest version. You?

cxj commented 4 years ago

(Sorry for any confusion I may cause with switching between my 2 GitHub accounts, personal and employer).

Would it perhaps be preferable to update require-dev to version 8? Or, one could argue for version 9 on the basis that PHP 7.1 hit End-Of-Life for security support on 30 November 2019 and PHP 7.2 likewise hit end of active support on the same date.

frederikbosch commented 4 years ago

Oh, yes, I am moving my current projects to PHPUnit 8.

cxj commented 4 years ago

I'll attempt to re-roll this PR with an update to require-dev for PHPUnit 8, ok?

frederikbosch commented 4 years ago

Thanks!

cxj commented 4 years ago

Thank you for the quick action! This will make migrating my web applications to PHP 7.4 that much easier and quicker.