search

auraphp / Aura.Di

Dependency Injection System
MIT License
349 stars 63 forks source link

use 7.2 onwards #206

Closed harikt closed 2 years ago

harikt commented 2 years ago

Hi @frederikbosch ,

In PR https://github.com/auraphp/Aura.Di/pull/203 the php version was raised. But according to the principles of Aura if we raise the php version we should consider it as a major one.

Even though the 7.4 is in security mode we should consider people who have started using it from 7.2.

As there is no BC break in that PR apart from the php version, we should keep the CI and change the composer.json .

Please do consider this.

Thank you

harikt commented 2 years ago

Regarding the ci build the lowest version. I wonder it should be called latest version? Anyway that one is failing, but all the versions is working as expected.