search

auraphp / Aura.Di

Dependency Injection System
MIT License
349 stars 63 forks source link

Unused `use` cleaned up #37

Closed donatj closed 10 years ago

harikt commented 10 years ago

This is not an unused use statement.

The namespace is Aura\Di , and Aura\Di\Container is used. It is always good to have the use statement though it is not necessary when a namespace is there.

I feel good to have a consistency here.

donatj commented 10 years ago

It is technically useless though, and I feel the changing namespace argument is moot.

Using absolute paths for all your classes incase something changes is kind of silly because let's say the namespace on container were to change, now you have to update all these absolute paths, it's silly.

Moreover, changing an objects namespace by hand is huge messy task and I'd absolutely recomend using a good refactoring tool (read: phpStorm) which would correct any relative ones and add the necessary namespaces.

pmjones commented 10 years ago

I get where @harikt is coming from here. Even so, I think this is harmless, and probably more consistent overall. Thanks @donatj for the attention to detail.