search

auraphp / Aura.Di

Dependency Injection System
MIT License
349 stars 63 forks source link

get all traits of ancestor classes & ancestor traits #75

Closed aMoniker closed 9 years ago

aMoniker commented 9 years ago

useful when using setters in traits

harikt commented 9 years ago

Thank you for the PR. Paul will look into this and merge.

shadowhand commented 9 years ago

I don't have anything else to say, other than the addition of a unit test would be 110%. :+1:

harikt commented 9 years ago

Thank you @aMoniker and @shadowhand for the great reviews. I am ok with this.

@pmjones seems busy these days. So may take a bit time. Please be patient and use the composer functionality to make things work at your end if you are looking on to work on this.

Thank you.

shadowhand commented 9 years ago

2.0 and 2.1 released without merging this? :(

harikt commented 9 years ago

@shadowhand 2.0 and 2.1 released before 26 Nov 2014 . https://github.com/auraphp/Aura.Di/releases/tag/2.1.0 . Ask Paul over irc . He was asking this http://colabti.org/irclogger/irclogger_log/auraphp?date=2015-01-05#l33

shadowhand commented 9 years ago

@harikt oops my mistake, I did not realize 2.1 was that old.

pmjones commented 9 years ago

I get the feeling there is some greater optimization to be had here, but I don't quite see what it is yet.