auraphp / Aura.Di

Dependency Injection System
MIT License
349 stars 63 forks source link

remove return #86

Closed koriym closed 9 years ago

koriym commented 9 years ago

The value of return mergeParams seems not used.

pmjones commented 9 years ago

The return is there to short-circuit the rest of the method. Would it be more clear if it were on two lines; i.e., "mergeParamEmpty()" and then "return" after that?

koriym commented 9 years ago

@pmjones yes, two lines seems clear.

koriym commented 9 years ago

@pmjones thanks.