search

auraphp / Aura.Di

Dependency Injection System
MIT License
349 stars 63 forks source link

Removing param read-only values, since they are in fact mutable. Fixes #91. #93

Closed brandonsavage closed 9 years ago

harikt commented 9 years ago

Further looking to merge, I find the commits that introduced for fixing @scrutinizer-ci https://github.com/auraphp/Aura.Di/commit/033fbe9eae64b37d2174fb3e500c1ca202a823ed .

I will wait for @pmjones .

harikt commented 9 years ago

Similar one, but https://github.com/auraphp/Aura.Di/pull/103 seems right to go ?

brandonsavage commented 9 years ago

They're essentially identical.

On Sun, Sep 13, 2015 at 5:12 AM, Hari K T notifications@github.com wrote:

Similar one, but this #103 https://github.com/auraphp/Aura.Di/pull/103 seems right to go ?

— Reply to this email directly or view it on GitHub https://github.com/auraphp/Aura.Di/pull/93#issuecomment-139855326.

brandonsavage commented 9 years ago

@pmjones Can we get a decision on merging this?

harikt commented 9 years ago

@brandonsavage In this PR I see the @property-read tag removed. But on the other we have @property tag . So may be it will help the @scrutinizer also.

I am not sure though.

pmjones commented 9 years ago

Sorry to take so long. Accepting, but may re-introduce other @property tags to soothe Scrutinizer, and to make PHPStorm recognize the that properties at least exist.