search

auraphp / Aura.Filter

Validate and sanitize arrays and objects.
MIT License
159 stars 33 forks source link

Remove 5.6 till 7.3 #145

Closed harikt closed 2 years ago

harikt commented 2 years ago

Hi @brandonsavage, @koriym,

I have been thinking of removing support from 5.6 to 7.3 and moving to 4.x which supports 7.4 to 8.1.

So we don't need to worry about newer language features and phpunit breaks.

Do you guys have any hard feelings on this?

koriym commented 2 years ago

Generally, dropping support for a deprecated PHP version is not a bad thing.

However, looking back over the past several years, I think the only obstacles to the continuation of the Aura project have been changes in external services such as CI, backward compatibility breakage in phpunit, (or neglected issues and PRs), and old PHP support has rarely been an obstacle. (Please let me know if I'm wrong)

harikt commented 2 years ago

Hey @koriym ,

I agree with you.

Regarding php versions I was looking at https://packagist.org/php-statistics dated on 2021-05-19 5.3 to 7.1 less than 4 % . So I believe dropping is not an issue.