search

auraphp / Aura.Input

Tools to describe HTML form fields and values.
MIT License
65 stars 11 forks source link

Starting 3.x #51

Closed harikt closed 6 years ago

harikt commented 8 years ago

Hi all,

I am currently cleaning up the Aura.Input 1.x branch in order to move it to 3.x.

Are there any feature request / problems we need to resolve ?

Please create issues or discuss here.

Thank you

jakejohns commented 7 years ago

Is the plan here to figure out how to integrate Filter and Input via a 3rd FilterInterface package?

harikt commented 7 years ago

Hi @jakejohns ,

I have some plans for intergration of Aura.Input and Aura.Filter with a common Interface.

See https://github.com/auraphp/Aura.Input/blob/712aaa48785a9ab3e34f5e70199b53a8596a76e7/composer.json#L27

The basic idea is if Aura.Filter is going to release 3.x we could make use of https://github.com/harikt/Aura.Filter_Interface/blob/7104e5554d04c8111c13914ed805c13c2218e0d0/src/FilterInterface.php and https://github.com/harikt/Aura.Filter_Interface/blob/7104e5554d04c8111c13914ed805c13c2218e0d0/src/FailureCollectionInterface.php , so there is no need of a 3rd package to integrate Aura.Input and Aura.Filter .

I have made the necessary changes and believe is good for review.

Let me know if that helps.

harikt commented 7 years ago

@pmjones Do you have any thoughts for the Filter_Interface ?

UPDATE :

If you think its worth to move out of the repo or keep it inside the same repo ? Keeping it inside the same means there need a wrapper for Aura.Filter . Else it would have been easy.

Thank you.

pmjones commented 7 years ago

Hi @harikt -- I like the idea of a Filter_Interface package. :-)

harikt commented 7 years ago

@pmjones then its time for you to create the repo for it and so we can push some code.

We can also do something like you did for pds/skelton also if needed ;-)

Thank you.

pmjones commented 7 years ago

Done! You're also now an owner on the repo. :-)

harikt commented 7 years ago

Thank you :-) . Do you have any thoughts / feedback on the interface itself ?

pmjones commented 7 years ago

AFAICT they match what we have already, so they look fine to me -- nicely done. (I reserve the right to change my mind. ;-)

harikt commented 7 years ago

I pushed the code : https://github.com/auraphp/Aura.Filter_Interface .

Will try to work on Aura.Input this weekend.

harikt commented 7 years ago

Some concerns are raised on https://github.com/auraphp/Aura.Input/issues/66 . Looks right to me.

harikt commented 6 years ago

I am closing this issue, for we have only one concern now which @jakejohns has raised in #66 .