Enable PHP 7.2-8.1 compat

auraphp / Aura.Router

A web router implementation for PHP.

http://auraphp.com/packages/3.x/Router/

MIT License

494 stars 74 forks source link

Closed koriym closed 2 years ago

harikt commented 2 years ago

Oh very late to the party. I see the PR is on 2021. Sorry missed to notice it.

koriym commented 2 years ago

: Does scrutinizer really work ?

@harikt

It is no longer necessary to run phpcs or phpmd with scrutinizer (there is GH Actions if needed), and I am not objecting to excluding scrutinizer.

Only scrutinizer's own php analyzer is still valid. It's easy and working now.

koriym commented 2 years ago

@harikt Besides, I think it would be good to demonstrate the high score (10.00 !) thanks to @pmjones' clean code (The real reason I'm keeping it :)