search

auraphp / Aura.SqlQuery

Independent query builders for MySQL, PostgreSQL, SQLite, and Microsoft SQL Server.
MIT License
452 stars 86 forks source link

add missing public methods to SelectInterface and related. #112

Closed pavarnos closed 7 years ago

pavarnos commented 7 years ago

make reset() public and add isDistinct() to round out the interface.

harikt commented 7 years ago

I will leave this to @pmjones for further review.

pavarnos commented 7 years ago

should we do UpdateInterface and InsertInterface here? The changes are mostly pretty simple (copying the declaration from the real class to the interface declaration). So they should be easy to review as one PR. What do you think?

harikt commented 7 years ago

I feel separate may help. The benefit is if something is likely not going to merge can be rejected other PR can get merged.

pavarnos commented 7 years ago

this is (hopefully) the last of the changes needed to fill out the *Interface classes. I'd originally planned to do this as 2 separate PRs, but found that the changes for the second PR were so small it wasn't worth it So they are all together here.