Remove SubSelect interface, typehint on SelectInterface instead

auraphp / Aura.SqlQuery

Independent query builders for MySQL, PostgreSQL, SQLite, and Microsoft SQL Server.

MIT License

452 stars 86 forks source link

Remove SubSelect interface, typehint on SelectInterface instead #133

Closed pmjones closed 7 years ago

pmjones commented 7 years ago

Per my comment on #108, this PR typehints binding of sub-select statements on SelectInterface, not SubselectInterface (which was originally introduced as a BC-mitigator).

pmjones commented 7 years ago

@harikt @pavarnos @auroraeosrose Please comment as convenient!

harikt commented 7 years ago

Probably when breaking changes are happening, it may be good to add in changelog also. So we don't forget or want to do look for the changes.