search

auraphp / Aura.SqlQuery

Independent query builders for MySQL, PostgreSQL, SQLite, and Microsoft SQL Server.
MIT License
450 stars 86 forks source link

Add ignore() method to common Insert class #173

Closed maximTarleckiy closed 2 years ago

maximTarleckiy commented 4 years ago

https://github.com/auraphp/Aura.SqlQuery/issues/172

harikt commented 2 years ago

I agree with you. It looks orIgnore seems to be used inside update also.

Only question here is do we want to use $inser->ignore() or $inser->orIgnore().

NaokiTsuchiya commented 2 years ago

LGTM

harikt commented 2 years ago

@koriym , @NaokiTsuchiya please do make sure other methods are also changed.

koriym commented 2 years ago

@harikt Sorry we missed it.

harikt commented 2 years ago

As we move to 3.x BC is not an issue. But I wish we could address using ignore or ignoreOr

koriym commented 2 years ago

@harikt orIgnore method marked @deprecated?

harikt commented 2 years ago

That is the change in this PR. But I doubt about it.