search

auraphp / Aura.SqlQuery

Independent query builders for MySQL, PostgreSQL, SQLite, and Microsoft SQL Server.
MIT License
452 stars 86 forks source link

Refactor #162 #198

Closed koriym closed 2 years ago

koriym commented 2 years ago

The nesting of if was not easy to read, so I created a method.

See https://github.com/auraphp/Aura.SqlQuery/pull/198/commits/66333facc3ec34cb16e75676798567c9f9af48c6

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (3.x@a4fd8dc). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             3.x     #198   +/-   ##
======================================
  Coverage       ?   99.87%           
  Complexity     ?      279           
======================================
  Files          ?       34           
  Lines          ?      809           
  Branches       ?        0           
======================================
  Hits           ?      808           
  Misses         ?        1           
  Partials       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4fd8dc...66333fa. Read the comment docs.

harikt commented 2 years ago

Thank you @koriym .