search

aurbano / robinhood-node

:chart_with_upwards_trend: NodeJS client for Robinhood Trading :fire:
https://aurbano.github.io/robinhood-node
MIT License
694 stars 184 forks source link

feat: add typescript support via typings file #83

Closed evanshortiss closed 6 years ago

evanshortiss commented 6 years ago

This will add support for typescript users and (I believe) should also add improved intellisense for JS users in VSCode.

I added the .editorconfig file since my editor was defaulting to 4 spaces whereas the project seems to use 2. The .editorconfig will help enforce that.

evanshortiss commented 6 years ago

Resolves #81

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 44.118% when pulling 46a736e730d3a07e437a270cd938d3f6f52c404a on evanshortiss:ts-types into 71457ba3db561f7cfa0f2a926f2674a263ffc611 on aurbano:master.

evanshortiss commented 6 years ago

@aurbano this is ready now. The MFA references are removed until the authentication stuff is resolved - I'll gladly PR it back when required.

The README might also need an update since it still references it.

aurbano commented 6 years ago

@evanshortiss awesome I'll merge, edit the README and release a new version with it 😄

evanshortiss commented 6 years ago

Thanks @aurbano