search

aurelg / feedspora

FeedSpora posts RSS/Atom feeds to your social network accounts.
35 stars 5 forks source link

Optionally employ URL shortener services for Twitter links posted. #12

Closed wilddeej closed 5 years ago

wilddeej commented 5 years ago

Enabled via the optional TweepyClient url_shortener variable setting, an attempt at shortening the URL link to include in the tweet is made, using the specified service. If this attempt fails for any reason, the unmodified link is used instead. Supported URL shortening services include 'Chilpit', 'Clkru', 'Dagd', 'Isgd', 'Osdb', 'Qpsru', 'Readability', 'Sentala', 'Soogd', and 'Tinyurl' - case does not matter, and any other setting is silently ignored and no URL shortening is applied.

aurelg commented 5 years ago

Thanks a lot, that's a very convenient addition. I had a quick look at pyshorteners (here?), and I can see that it supports other shorteners you do not mention (namely adfly, bitly, owly, post and tinycc), and some of those you mentioned in the PR are missing from the website (Readability, Sentala and Soogd). Is there a reason for this?

wilddeej commented 5 years ago

I only implemented the ones that don't require any keys/tokens, at least for now. Unfortunately, pyshorteners is suffering from some version issues, in that the document is WAY out of date, and the "pip install" version (here https://pypi.org/project/pyshorteners/) is several versions behind the latest source code (here https://github.com/ellisonleao/pyshorteners/). I plan on resolving this in an upcoming enhancement to use the source version, as well as adding support for shorteners that require keys/tokens. For now this is quite functional, and I've used the Isgd, Dagd, and Osdb shorteners with good result. I did, unfortunately, just try Soogd for the first time and found out it was not implemented in the "pip install" version, so that is a definite mistake. It's possible there are other missing implementations that I didn't test.

On Sat, Nov 17, 2018 at 7:36 AM Aurélien Grosdidier < notifications@github.com> wrote:

Thanks a lot, that's a very convenient addition. I had a quick look at pyshorteners (here? https://pyshorteners.readthedocs.io/en/latest/), and I can see that it supports other shorteners you do not mention (namely adfly, bitly, owly, post and tinycc), and some of those you mentioned in the PR and missing from the website (Readability, Sentala and Soogd). Is there a reason for this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aurelg/feedspora/pull/12#issuecomment-439621713, or mute the thread https://github.com/notifications/unsubscribe-auth/AXIWhpxQtayDZunN_utdCtLN7ySNZualks5uwB7agaJpZM4YneJJ .

aurelg commented 5 years ago

Btw, python-yourls could be an interesting additions, yourls looks really nice :-)

wilddeej commented 5 years ago

I'll be sure and give it a closer look!

On Sat, Nov 17, 2018 at 12:34 PM Aurélien Grosdidier < notifications@github.com> wrote:

Btw, python-yourls https://github.com/tflink/python-yourls could be an interesting additions, yourls https://yourls.org looks really nice :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aurelg/feedspora/pull/12#issuecomment-439641936, or mute the thread https://github.com/notifications/unsubscribe-auth/AXIWhnOgA-AqNMC9iOJvdel9L9i0yS0gks5uwGTVgaJpZM4YneJJ .