Closed wilddeej closed 5 years ago
aurelg
commented
5 years ago Nice feature, thanks. Users won't expect different behavior between the Atom and RSS feeds. I think it's extremely important to keep them on par feature-wise. Since it's trivial, it's certainly worth implementing it in this PR.
wilddeej
commented
5 years ago I included some commented-out code for just that purpose, but I didn't want to fully put it in without some decent testing. Can you suggest a good Atom feed that I could access for this purpose?
On Tue, Nov 20, 2018 at 1:00 PM Aurélien Grosdidier < notifications@github.com> wrote:
Nice feature, thanks. Users won't expect different behavior between the Atom and RSS feeds. I think it's extremely important to keep them on par feature-wise. Since it's trivial, it's certainly worth implementing it in this PR.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aurelg/feedspora/pull/18#issuecomment-440410635, or mute the thread https://github.com/notifications/unsubscribe-auth/AXIWhjDB3zjA_aolSxLzC0LYH4Bvs93Oks5uxF95gaJpZM4YrV7n .
wilddeej
commented
5 years ago I poked around and was able to find an Atom feed at http://www.javarticles.com/feed/atom. It revealed a bug in the Tweepy implementation that I will fix in the next PR. I've pushed another change to PR #18 to include the Atom feed implementation of this new enhancement, as requested.
On Tue, Nov 20, 2018 at 3:06 PM Jim Howard wilddeej@gmail.com wrote:
I included some commented-out code for just that purpose, but I didn't want to fully put it in without some decent testing. Can you suggest a good Atom feed that I could access for this purpose?
On Tue, Nov 20, 2018 at 1:00 PM Aurélien Grosdidier < notifications@github.com> wrote:
Nice feature, thanks. Users won't expect different behavior between the Atom and RSS feeds. I think it's extremely important to keep them on par feature-wise. Since it's trivial, it's certainly worth implementing it in this PR.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aurelg/feedspora/pull/18#issuecomment-440410635, or mute the thread https://github.com/notifications/unsubscribe-auth/AXIWhjDB3zjA_aolSxLzC0LYH4Bvs93Oks5uxF95gaJpZM4YrV7n .
wilddeej
commented
5 years ago I think this one is complete and ready to be merged, unless you have something else that needs to be done with it.
On Tue, Nov 20, 2018 at 3:59 PM Jim Howard wilddeej@gmail.com wrote:
I poked around and was able to find an Atom feed at http://www.javarticles.com/feed/atom. It revealed a bug in the Tweepy implementation that I will fix in the next PR. I've pushed another change to PR #18 to include the Atom feed implementation of this new enhancement, as requested.
On Tue, Nov 20, 2018 at 3:06 PM Jim Howard wilddeej@gmail.com wrote:
I included some commented-out code for just that purpose, but I didn't want to fully put it in without some decent testing. Can you suggest a good Atom feed that I could access for this purpose?
On Tue, Nov 20, 2018 at 1:00 PM Aurélien Grosdidier < notifications@github.com> wrote:
Nice feature, thanks. Users won't expect different behavior between the Atom and RSS feeds. I think it's extremely important to keep them on par feature-wise. Since it's trivial, it's certainly worth implementing it in this PR.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aurelg/feedspora/pull/18#issuecomment-440410635, or mute the thread https://github.com/notifications/unsubscribe-auth/AXIWhjDB3zjA_aolSxLzC0LYH4Bvs93Oks5uxF95gaJpZM4YrV7n .
If an item's information includes the date upon which it was published, this information is used as part of the "published" database entry, along with the relevant link. This allows an item with the same link to be published again later, as long as its published date is different. For those items containing no publication date, the former behavior is unchanged (using the link information only). Only the RSS feed implementation for this feature is in place at this point, but it would be trivial to implement this functionality for Atom feeds as well, by setting the FeedSporaEntry's published_date attribute with the relevant Atom field content.