search

aurelhubert / ahbottomnavigation

A library to reproduce the behavior of the Bottom Navigation guidelines from Material Design.
3.84k stars 682 forks source link

Add support for any FloatingActionButton library #295

Open rishirajrandive opened 6 years ago

rishirajrandive commented 6 years ago

Any great library for making fancy FABs/ FAB menu could be used with AHBottomNavigation The changes here:

  1. Make manageFloatingActionButtonBehavior methods to generic.
  2. Update DemoActivity to accommodate the changed methods. Where only one more argument is added to manageFloatingActionButtonBehavior() method, the argument is 'factor' which is used for positioning the Y of FAB or FAB menu.
Rainer-Lang commented 6 years ago

@rishirajrandive Clans FAB isn't maintained anymore. There are other alternative libs which are very good maintained. IMHO even in the demo there shouldn't be an old lib.

rishirajrandive commented 6 years ago

Thanks! @Rainer-Lang, it makes sense. I was not aware of other libraries like Clans FAB and I used Clans FAB in my project along with AhBottomNavigation, so I ended up making this change.

Rainer-Lang commented 6 years ago

@rishirajrandive It's ok. Have a look here: https://github.com/jahirfiquitiva/FABsMenu

rishirajrandive commented 6 years ago

@Rainer-Lang thank you for the library, will this work with ahbottomnavigation?

Rainer-Lang commented 6 years ago

@rishirajrandive I really don't know. Sorry. But if you test it - please give feedback here or even better change your PR. :-)

rishirajrandive commented 6 years ago

@Rainer-Lang I checked for the suggested library, changes in the pull request work well with it. Changes in pull request are generic and not dependent on any library.