search

aurelia-contrib / aurelia-open-id-connect

An aurelia adapter for the IdentityModel/oidc-client-js
https://zamboni-app.azurewebsites.net
MIT License
54 stars 18 forks source link

chore (All), fix(typings) #44

Closed gerbendekker closed 6 years ago

gerbendekker commented 6 years ago

This still contains bug, doing pull request to coop. Please advise to check the src file changes because they contain assumption to correct strict typescript issues.

gerbendekker commented 6 years ago

@shaunluttin I'm ready with the pull request. The tests are working and successful. The package is checked with 'aurelia-app-identity-server-aspnetcore' and working.

gerbendekker commented 6 years ago

1 item remains, I excluded the test folder from tsconfig.json. If I remove it then it triggers a "is not under 'rootDir'" maybe still use the tsconfig.test.json but I leave that up to you.

gerbendekker commented 6 years ago

btw, fix (DI): autoinject to inject - c0f56d4 could also be resolved with "emitDecoratorMetadata": true in 'tsconfig.json'.

TypeScript's emitDecoratorMetadata flag causes the TypeScript compiler to polyfill the Metadata Reflection API and add a special decorator definition to the transpiled TypeScript code.

Because of the polyfill not always used in libs/plugins, but I leave that decision up to you to make.

shaunluttin commented 6 years ago

Thank you for this PR.

I ended up cherry-picking many of the changes instead of merging the entire PR. You can see the changes in the 0.24.1 release. I have also updated the contributors list.

If there are other changes that you made that you think would be worth including, and that I did not cherry-pick, please either

  1. create a new PR or
  2. fix the branch conflicts in this PR.

Thank you again. The ASP.NET Core project now builds without errors! 👏 👏 👏

https://github.com/shaunluttin/aurelia-open-id-connect/blob/master/package.json#L10-L14

gerbendekker commented 6 years ago

Your welcome, thanks for appreciating the work. Its hard to make no branch conflicts when reorganizing a lot. If all set, then it would be good to look at #8 .