search

aurelia-contrib / aurelia-open-id-connect

An aurelia adapter for the IdentityModel/oidc-client-js
https://zamboni-app.azurewebsites.net
MIT License
54 stars 18 forks source link

Login popup window? #59

Open HIRANO-Satoshi opened 5 years ago

HIRANO-Satoshi commented 5 years ago

Hi,

As login requires transition to a login page where is apart from Aurelia, downloading the bundle occurs twice, before and after login. That was mentioned in #24 and seems stucking.

But the oidc-client-js should work with a popup login window as its sample does, right? Is there any reason why you don't use it? Difficult to use?

https://github.com/IdentityModel/oidc-client-js/blob/dev/samples/VanillaJS/public/user-manager-sample-popup-signin.html

arnederuwe commented 5 years ago

It's definitely possible, but this plugin was designed to plug into the Aurelia router, creating the OIDC redirect routes for you and handling them. You would need another system for pop-ups, as the redirect routes would not hit the Aurelia app itself but the pop-up. @shaunluttin are you open for a pull request on this? I would like to give it a shot

HIRANO-Satoshi commented 5 years ago

Thanks.

Since I am using another library, I would like to close this issue.

arnederuwe commented 5 years ago

Since it's not fixed, I would rather leave it open as a feature request :)

HIRANO-Satoshi commented 5 years ago

all right.