search

aurelia-ui-toolkits / aurelia-kendoui-bridge

MIT License
117 stars 31 forks source link

Problem with bundling aurelia-kendoui-bridge #531

Closed eliavmaman closed 8 years ago

eliavmaman commented 8 years ago

Hey, i m using the es6 skeleton and try to bundle all files now. i have a vendor folder that include all Kendo core files. When i type gulp bundle, i get gulp-notify: [Error running Gulp] Error: C:/projects/skeleton-es2016/src/vendors/js/kendo.all.min.js: Argument name clash in strict mode (76:3565).

Should i change anything to make it work?

JeroenVinke commented 8 years ago

Please check this article and this config with bundling

eliavmaman commented 8 years ago

@JeroenVinke i still find it difficult to implement. here is my skeleton project image the vendors folder contains all kendo file which failed to bundle. This is my bundle.js image I've added the exclude section and declare the src/vendor folder to do not get bundle.

Any idea mate?

JeroenVinke commented 8 years ago

I would put the vendors folder outside of the src folder (link to instructions), then you need to make sure you have a this line in the paths section of config.js:

"kendo-ui/*": "vendors/*"

You will probably need to change your app.html as well so that it uses the kendo-ui map:

 <require from="kendo-ui/styles/kendo.common.min.css!"></require>
 <require from="kendo-ui/styles/kendo.bootstrap.min.css!"></require>

Then you can add this bundle configuration and you probably don't need this anymore:

"excludes": [
  "[src/vendors/**/*.js]"
]
eliavmaman commented 8 years ago

10x man i'll try that

eliavmaman commented 8 years ago

@JeroenVinke sorry for not reply yesterday, was struggled with the bundle issues. i did exactly what u said, i get this error now when i bundle. It's looks like the the jquery.min.map file in vendor folder cozing the issue..

image

have u seen that b4?

JeroenVinke commented 8 years ago

Nope, haven't seen that before. It's weird because it shouldn't be bundling .map files.What does your bundle config look like now? Also, if you don't mind you could also remove the .map files from the folder

eliavmaman commented 8 years ago

remove the map files from vendor folder?

JeroenVinke commented 8 years ago

Yes

eliavmaman commented 8 years ago

my bundle.js: image

JeroenVinke commented 8 years ago

a couple of things:

  1. what version of jspm are you on? (jspm -v)
  2. set depCache to false
  3. We don't need this, but you could try to change "includes": ["kendo-ui/js/*"], to "includes": ["kendo-ui/js/*.js"], if you don't want to remove the .map files
eliavmaman commented 8 years ago

my jspm v is 0.16.15

eliavmaman commented 8 years ago

@JeroenVinke sorry for asking that, but i feel i quite misunderstood the integration between the config.js and bundle.js. when i first saw aurelia movie, it's sayed that we don't really need to touch it. but it seem that there is a lot to deal with the config files.

and i don't mind to to that ' it just i really want to understand the configuration of an aurelia project a bit more then JSPM install this and that. May b a good article or short explanation and i'll buy u a beer.

eliavmaman commented 8 years ago

I dont know what to do... now gulp bundle ,watch ,build they are all stuck after css image

JeroenVinke commented 8 years ago

@eliavmaman keep an eye on https://github.com/aurelia-ui-toolkits/aurelia-kendoui-bridge/issues/534, hopefully that will help you out

JeroenVinke commented 8 years ago

@eliavmaman https://aurelia-ui-toolkits.gitbooks.io/kendoui-bridge-docs/content/app_developers_notes/bundlingstep_by_step_instructions_md.html should help you out, and if it still doesn't work then something is probably wrong in your setup