search

aurelia-ui-toolkits / aurelia-kendoui-bridge

MIT License
117 stars 31 forks source link

Changed $ to kendo.jQuery in template handling #784

Closed chris-howden closed 6 years ago

chris-howden commented 6 years ago

I have a project where the usual suggestions to handle "$ is undefined" errors (webpack plugin, script tag to import jQuery, etc.) either don't work or unacceptable.

After looking at the code and the docs for this project it seems that referencing $ is not acceptable and should be kendo.jQuery, which is guaranteed to be available.

JeroenVinke commented 6 years ago

@arnederuwe this looks good to me. Using kendo.jQuery also prevents issues where jquery is loaded twice

arnederuwe commented 6 years ago

@chris-howden thanks for the contribution! I will try to fix our CI build first and will merge after that