search

aurelia-ui-toolkits / aurelia-materialize-bridge

Materialize CSS components for Aurelia
http://aurelia-ui-toolkits.github.io/demo-materialize/
MIT License
156 stars 53 forks source link

Errors in bundling with aurelia-bundler ^0.7.0 and "systemjs-builder": "^0.16.9". #533

Closed nndevstudio closed 5 years ago

nndevstudio commented 5 years ago

Considering this issue: https://github.com/aurelia/bundler/commit/98215c1c4e1fad84803fe7366c27a453a93f1ddb#commitcomment-30808714 is there any workaround so we can bundle aurelia-materialize-bridge 1.1.0 properly?

MaximBalaganskiy commented 5 years ago

One of the build steps of the demo app is creating a jspm bundle for the gists. You can have a look how it is done there. I've got a very limited access to the internet (vacation) so will only be able to have a look after 20th of October

MaximBalaganskiy commented 5 years ago

Basically, you don't really need an aurelia bundler - jspm cli can to this task just fine.

nndevstudio commented 5 years ago

Thanks Max, great tip with demo-materialize project and jspm.config.js approach. Unfortunately we are not so experienced for native jspm bundling so in this moment we experiment with downgraded aurelia-bundler v. 0.5.0. It seems that it works.

MaximBalaganskiy commented 5 years ago

There is not much to it. Just one cli command where you list the packages you want in the bundle. You can see it in package.json under bundle:jspm script

On Tue., 9 Oct. 2018, 5:04 pm Nemanja Novicic, notifications@github.com wrote:

Thanks Max, great tip with demo-materialize project and jspm.config.js approach. Unfortunately we are not so experienced for native jspm bundling so in this moment we experiment with downgraded aurelia-bundler v. 0.5.0. It seems that it works.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aurelia-ui-toolkits/aurelia-materialize-bridge/issues/533#issuecomment-428228782, or mute the thread https://github.com/notifications/unsubscribe-auth/ADimvIy4nLJoAxEjw54ujzqRbpAwr1cqks5ujLr6gaJpZM4XMglf .

nndevstudio commented 5 years ago

I must ask you, can this bundle:jspm approach be used with bundles.js file and already configured gulp task in tasks/bundle.js so instead of var bundler = require('aurelia-bundler'); we can use something like var bundler = require('jspm only'); ?

We rely on bundles.js configuration because one part of application can work in "execution only" mode so it does not need all components. But in case when the user is signed in then all bundles are requested.

MaximBalaganskiy commented 5 years ago

You can require jspm from a js script as far as I know. How to integrate that with gulp I don't know unfortunately.

On Mon., 15 Oct. 2018, 3:37 pm Nemanja Novicic, notifications@github.com wrote:

I must ask you, can this bundle:jspm approach be used with bundles.js file and already configured gulp task in tasks/bundle.js so instead of var bundler = require('aurelia-bundler'); we can use something like var bundler = require('jspm only'); ?

We rely on bundles.js configuration because one part of application can work in "execution only" mode so it does not need all components. But in case when the user is signed in then all bundles are requested.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aurelia-ui-toolkits/aurelia-materialize-bridge/issues/533#issuecomment-429756146, or mute the thread https://github.com/notifications/unsubscribe-auth/ADimvL5hoZEkJI3gTRjQVcsl1K20TGa4ks5ulEk0gaJpZM4XMglf .