aurelia-ui-toolkits / aurelia-materialize-bridge

Materialize CSS components for Aurelia
http://aurelia-ui-toolkits.github.io/demo-materialize/
MIT License
156 stars 53 forks source link

fix(radio): allow model binding with boolean value 'false' #549

Closed pavsaund closed 5 years ago

pavsaund commented 5 years ago

The !model check falsely presumed that a model.bind="false" meant binding to the value attribute. This in turn binds the string value "false" instead of the boolean false. Aurelia's own documentation recommends binding boolean values with the model.bind="false" syntax. ref: https://aurelia.io/docs/binding/radios#booleans.

Though this could be considered a patch fix to match expected behaviour in Aurelia, apps in the wild may depend on the existing behaviour. It may therefore be worth considering making this a major bump due to breaking change.