search

aurelia-ui-toolkits / aurelia-materialize-bridge

Materialize CSS components for Aurelia
http://aurelia-ui-toolkits.github.io/demo-materialize/
MIT License
156 stars 53 forks source link

Missing gulpfile #551

Closed OtherLeadingBrand closed 5 years ago

OtherLeadingBrand commented 5 years ago

Sometime in the past around Feb 25, 2018 Commit ID: 7d461833ecae91b7a86a54b82c81092739c4f0f the build sub directory and the related gulpfile.js were removed from the project. This causes the gulp commands in the documentation to fail because there is no existing gulp configuration.

Does the documentation need to be updated to include new build instructions? Apologies if I'm missing a step here.

MaximBalaganskiy commented 5 years ago

Any gulp stuff is a leftover. Npm run build should build the project

On Tue, Aug 20, 2019, 12:02 AM OtherLeadingBrand notifications@github.com wrote:

I apologize if this is a rudimentary issue. After cloning the repo, running both npm/jspm install there is no gulpfile.js in the root of the project. This of course prevents gulp build or test from running as a task.

Should this file have been generated automatically as an artifact of a previous step or am I missing a fundamental step in the clone/build process?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aurelia-ui-toolkits/aurelia-materialize-bridge/issues/551?email_source=notifications&email_token=AA4KNPH6T4POEDFCY42FSWTQFKRWBA5CNFSM4INCASLKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HF7Y7MA, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4KNPBVZTST2GQHDOJYPUDQFKRWBANCNFSM4INCASLA .

OtherLeadingBrand commented 5 years ago

Thanks for the quick feedback. I was able to build using npm run build yesterday.

I see that both the "test" and "ci" scripts in package.json use "gulp test" and "gulp ci". Are the unit tests now ran via a different method than documented?

MaximBalaganskiy commented 5 years ago

Unfortunately, docs are out of date. There are no tests at the moment. It's always been monkey tested :)

On Tue, Aug 20, 2019, 9:59 PM OtherLeadingBrand notifications@github.com wrote:

Thanks for the quick feedback. I was able to build using npm run build yesterday.

I see that both the "test" and "ci" scripts in package.json use "gulp test" and "gulp ci". Are the unit tests now ran via a different method than documentation?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aurelia-ui-toolkits/aurelia-materialize-bridge/issues/551?email_source=notifications&email_token=AA4KNPAGZLV5M57ZV4CF45DQFPMDTA5CNFSM4INCASLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4WBBFY#issuecomment-522981527, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4KNPHX5NIBJLS6MWJT3TDQFPMDTANCNFSM4INCASLA .

OtherLeadingBrand commented 5 years ago

No problem Maxim. The monkeys are doing a great job thus far. Appreciate the feedback.